Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getRow method for dynamic table #648

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Fix getRow method for dynamic table #648

merged 8 commits into from
Jan 14, 2025

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Dec 12, 2024 •
edited
Loading

Motivation

Fix getRow method to work also if data is 2D

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (bb9acbf) to head (ee12937).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files         117      117           
  Lines        4901     4902    +1     
=======================================
+ Hits         4668     4669    +1     
  Misses        233      233

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehennestad ehennestad requested a review from bendichter January 2, 2025 13:52
bendichter
bendichter requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@bendichter bendichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@bendichter
Copy link
Contributor

@ehennestad do you know why these errors are occuring?

@ehennestad
Copy link
Collaborator Author

@ehennestad do you know why these errors are occuring?

#637 (comment)

@bendichter bendichter self-requested a review January 14, 2025 15:04
@bendichter bendichter merged commit ead90dd into master Jan 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendichter bendichter bendichter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehennestad @bendichter